Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node dependency from secure library #2033

Merged

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented May 27, 2019

This solves #1869

Looks like we are free of any circular dependencies between our libraries now.

Wasn't sure if stats.hpp/cpp should go into lib or secure, it only had lib dependencies so put it there, but the choice between these 2 libraries is not always obvious.

@wezrule wezrule added this to the V19.0 milestone May 27, 2019

@wezrule wezrule requested a review from cryptocode May 27, 2019

@wezrule wezrule self-assigned this May 27, 2019

@zhyatt zhyatt added this to During RC in V19 May 27, 2019

@wezrule wezrule merged commit b169798 into nanocurrency:master May 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:remove_node_dependency_from_secure_lib branch May 27, 2019

@zhyatt zhyatt moved this from During RC to RC 4 (TBD) in V19 May 30, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.