Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization order bug in nano::node #2042

Merged
merged 3 commits into from May 29, 2019

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented May 28, 2019

The wallet depends on confirmation_height_processor, and search_pending sometimes calls it before the node is fully constructed, causing a segfault.

@cryptocode cryptocode added the bug label May 28, 2019

@cryptocode cryptocode added this to the V19.0 milestone May 28, 2019

@cryptocode cryptocode requested a review from wezrule May 28, 2019

@cryptocode cryptocode self-assigned this May 28, 2019

@cryptocode cryptocode added this to RC 4 (TBD) in V19 May 28, 2019

Use a latch to deal with mutual deps between active transactions and …
…wallets; no initialization order will do

@cryptocode cryptocode merged commit b29ebbd into nanocurrency:master May 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:fix/node-init-order branch May 29, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Fix initialization order bug in nano::node (#2042)
* Fix initialization order bug in nano::node

* Use a latch to deal with mutual deps between active transactions and wallets; no initialization order will do

* Remove counter from initializer list as it's just calling the default ctor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.