Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active_transaction.roots bounding by config instead of confirmation rate #2051

Merged
merged 7 commits into from Jun 6, 2019

Conversation

@argakiig
Copy link
Collaborator

commented Jun 1, 2019

remove transaction counter and associated tests
only flush if roots.size() >= active_elections_size
active_elections_size added to config and re-factor simplified should_flush
update config v17 and upgrade path tests
ensure active_elections_size is 250 or greater

@argakiig argakiig added this to the V19.0 milestone Jun 1, 2019

@argakiig argakiig self-assigned this Jun 1, 2019

remove transaction counter and associated tests
only flush if roots.size() >= active_elections_size
acltive_elections_size added to config and re-factor simplified should_flush
update config v17 and upgrade path tests

@argakiig argakiig force-pushed the argakiig:fixed_trans_bounding branch from d6eb284 to 3a6e781 Jun 1, 2019

@argakiig argakiig requested review from wezrule, cryptocode and SergiySW Jun 1, 2019

@zhyatt zhyatt added this to RC 4 (TBD) in V19 Jun 2, 2019

argakiig added some commits Jun 3, 2019

move inactive to active_transactions
clear when it would fall out of scope prior

@argakiig argakiig force-pushed the argakiig:fixed_trans_bounding branch from bae83aa to b93ae6d Jun 3, 2019

Show resolved Hide resolved nano/node/nodeconfig.hpp Outdated
@cryptocode
Copy link
Collaborator

left a comment

LGTM

@wezrule

wezrule approved these changes Jun 6, 2019

@argakiig argakiig merged commit 1f46e05 into nanocurrency:master Jun 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@argakiig argakiig deleted the argakiig:fixed_trans_bounding branch Jun 6, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

active_transaction.roots bounding by config instead of confirmation r…
…ate (#2051)

* remove transaction counter and associated tests
only flush if roots.size() >= active_elections_size
acltive_elections_size added to config and re-factor simplified should_flush
update config v17 and upgrade path tests

* move inactive to active_transactions
clear when it would fall out of scope prior

* update tests and set default to 8k

* Revert "move inactive to active_transactions"

This reverts commit b93ae6d.

* merge from master cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.