Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce lock time in UDP ongoing keepalive #2057

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented Jun 2, 2019

While investigating a long held lock in vote processor, a few things popped up. This PR reduces lock time in UDP ongoing_keepalive the same way it's already done for TCP.

set_last_packet_sent removed since it's already called in channel->send (can you verify this is correct @SergiySW?)

Also removes a left-over weak_ptr.

@cryptocode cryptocode added this to the V19.0 milestone Jun 2, 2019

@cryptocode cryptocode requested a review from SergiySW Jun 2, 2019

@cryptocode cryptocode self-assigned this Jun 2, 2019

@zhyatt zhyatt added this to RC 4 (TBD) in V19 Jun 2, 2019

@SergiySW
Copy link
Collaborator

left a comment

LGTM

@cryptocode cryptocode merged commit cee2352 into nanocurrency:master Jun 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:perf-voteprocessor/ongoing_keepalive_udp branch Jun 2, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.