Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active container observer #2058

Merged
merged 13 commits into from Jun 5, 2019

Conversation

@SergiySW
Copy link
Collaborator

commented Jun 3, 2019

No description provided.

SergiySW added some commits Jun 3, 2019

@SergiySW SergiySW added the enhancement label Jun 3, 2019

@SergiySW SergiySW added this to the V19.0 milestone Jun 3, 2019

@SergiySW SergiySW requested review from argakiig and cryptocode Jun 3, 2019

@SergiySW SergiySW self-assigned this Jun 3, 2019

@zhyatt zhyatt added this to RC 4 (TBD) in V19 Jun 3, 2019

@SergiySW SergiySW force-pushed the SergiySW:active/observers branch from e1519d8 to a5eae54 Jun 3, 2019

@SergiySW SergiySW force-pushed the SergiySW:active/observers branch from 7d642b2 to d70d4c9 Jun 3, 2019

Show resolved Hide resolved nano/node/node.cpp Outdated
@argakiig
Copy link
Collaborator

left a comment

Lgtm

@SergiySW SergiySW removed the incomplete label Jun 5, 2019

@SergiySW SergiySW merged commit 0427117 into nanocurrency:master Jun 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

argakiig added a commit that referenced this pull request Jun 11, 2019

Add active container observer (#2058)
* Add active container observers

* Inserrt election into inactive after stopping in request_confirm ()

to remove from container

* Add functions clear_blocks (), clear_dependent ()

* confirm_once () should add record to history & remove election from container

* Update tests

* inactive_confirmation_height type

* Improve assertion

* Return election status to observer.blocks, add observers.active_stopped for cancelled elections

* Use unique_lock for active_transactions::confirm_block ()

* Remove draft part
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.