Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TSAN error with work_watcher #2061

Merged
merged 1 commit into from Jun 10, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Jun 5, 2019

Fix TSAN error found when running the wallet.send_race test:
https://gist.github.com/wezrule/409a4ad962e36f18c4f6c446232f2803

The issue is that we don't protect accesses to the block elements while iterating or check whether the work_watcher has been stopped where the blocks container has been modified. I am now copying some members and checking for stopped when it's not possible to do so.

@wezrule wezrule added the sanitizers label Jun 5, 2019

@wezrule wezrule added this to the V19.0 milestone Jun 5, 2019

@wezrule wezrule requested a review from argakiig Jun 5, 2019

@wezrule wezrule self-assigned this Jun 5, 2019

@zhyatt zhyatt added this to During RC in V19 Jun 6, 2019

@zhyatt zhyatt moved this from During RC to RC 4 (TBD) in V19 Jun 7, 2019

@wezrule wezrule merged commit 156a744 into nanocurrency:master Jun 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:tsan_wallet_send_race branch Jun 10, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.