Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket/extended confirmation support #2066

Conversation

@cryptocode
Copy link
Collaborator

commented Jun 7, 2019

Part 2 of #2058.

Includes stopped-election subscription, and option to get confirmations without full block info.

A documentation PR remains.

This could probably use some more unit tests. If we want this in quickly for testing confirmation callbacks, I could add those to a separate PR, otherwise I'll mark as incomplete.

cryptocode added some commits Jun 5, 2019

@cryptocode cryptocode added this to the V19.0 milestone Jun 7, 2019

@cryptocode cryptocode requested a review from SergiySW Jun 7, 2019

@cryptocode cryptocode self-assigned this Jun 7, 2019

cryptocode added some commits Jun 7, 2019

@cryptocode cryptocode added this to RC 4 (TBD) in V19 Jun 7, 2019

@zhyatt zhyatt added the documentation label Jun 7, 2019

@zhyatt zhyatt requested a review from wezrule Jun 7, 2019

Show resolved Hide resolved nano/node/websocket.cpp Outdated
@wezrule

wezrule approved these changes Jun 9, 2019

@cryptocode cryptocode merged commit c52e147 into nanocurrency:master Jun 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:websocket/extended_confirmation_support branch Jun 9, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Websocket/extended confirmation support (#2066)
* WS: Add support for confirmation without block contents

* Confirmation type filtering

* Remove debugging code

* Better comments

* Use if/else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.