Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Disable memory pools when running on Mac #2067
When running TSAN on Mac I get a warning with the
Although strangely only when the previous test is run as well, running this test on its own never showed the error. Running the node daemon reports continuous warnings though. After some research I found there seems to be some known issues with the thread sanitizer on mac with shared/weak_ptrs destructors:
I don't think it's enough to suppress these in the blacklist file as there are other following on TSAN errors as well. I spent a while trying to solve this, but I'm not sure if it's possible on our end, so it seemed best just to disable the warnings entirely. Builds on Ubuntu with both Clang & GCC do not report anything with TSAN. So I'm not sure if this is something we should be concerned about or not, would like opinions on it, perhaps other Mac users can run TSAN as well and see if they see any issues currently (I used Boost 1.69).
EDIT: For now disabling memory pools on Mac entirely, not just when using TSAN