Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out online_reps and gap_cache #2070

Merged

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented Jun 8, 2019

Part of #1112
Moves out corresponding classes and adds an erase function to gap_cache to improve encapsulation (though more work should be done here in the future) + adds a bit of doxygen docs.

@cryptocode cryptocode added this to the V19.0 milestone Jun 8, 2019

@cryptocode cryptocode requested a review from wezrule Jun 8, 2019

@cryptocode cryptocode self-assigned this Jun 8, 2019

@cryptocode cryptocode referenced this pull request Jun 8, 2019

Open

Break up and document node source #1112

12 of 14 tasks complete

@cryptocode cryptocode added this to RC 4 (TBD) in V19 Jun 8, 2019

@wezrule

wezrule approved these changes Jun 9, 2019

Copy link
Collaborator

left a comment

LGTM, just check if some of the includes are actually needed by the header file or whether they can go in the corresponding source file.

Show resolved Hide resolved nano/node/online_reps.hpp
Show resolved Hide resolved nano/node/gap_cache.hpp
Show resolved Hide resolved nano/node/online_reps.cpp

@cryptocode cryptocode merged commit dcaa95f into nanocurrency:master Jun 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:refactor/online_reps_gap_cache branch Jun 9, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Factor out online_reps and gap_cache (#2070)
* Factor out online_reps and gap_cache

* Formatting not dealt with by clang-format-all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.