Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert for disabled bootstrap modes #2163

Merged
merged 1 commit into from Jul 24, 2019
Merged

Assert for disabled bootstrap modes #2163

merged 1 commit into from Jul 24, 2019

Conversation

SergiySW
Copy link
Contributor

No description provided.

@SergiySW SergiySW added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Jul 20, 2019
@SergiySW SergiySW added this to the V20.0 milestone Jul 20, 2019
@SergiySW SergiySW self-assigned this Jul 20, 2019
@cryptocode cryptocode added documentation This item indicates the need for or supplies updated or expanded documentation rpc semantics change labels Jul 21, 2019
cryptocode
cryptocode approved these changes Jul 21, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added doc tag as RPC response may now be an error if disable_legacy_bootstrap is enabled. While this flag is default false, some people may have it on, so I also think marking this as a potentially breaking RPC change makes sense?

@SergiySW
Copy link
Contributor Author

@cryptocode indeed, thanks!

@SergiySW SergiySW added this to CP1 in V20 Jul 22, 2019
SergiySW added a commit to SergiySW/nano-docs that referenced this pull request Jul 22, 2019
@SergiySW
Changes from PR#2163
94e3588 
nanocurrency/nano-node#2163
@SergiySW SergiySW mentioned this pull request Jul 22, 2019
Merged
@SergiySW SergiySW merged commit 731822d into nanocurrency:master Jul 24, 2019
zhyatt pushed a commit to nanocurrency/nano-docs that referenced this pull request Jul 29, 2019
@SergiySW @zhyatt
Changes from PR#2163 (#57)
ecf5843 
nanocurrency/nano-node#2163
GuyWhoKnowsTheGuy pushed a commit to GuyWhoKnowsTheGuy/nano-docs that referenced this pull request Aug 9, 2019
@SergiySW @GuyWhoKnowsTheGuy
Changes from PR#2163 (nanocurrency#57)
9c90afb 
nanocurrency/nano-node#2163
@zhyatt zhyatt added rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted. and removed rpc semantics change labels Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
documentation This item indicates the need for or supplies updated or expanded documentation quality improvements This item indicates the need for or supplies changes that improve maintainability rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted.
Projects
No open projects
V20
CP1
Milestone
V20.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SergiySW @wezrule @cryptocode @zhyatt