Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify `wallet_create` CLI to allow seed & password change #719

Merged
merged 8 commits into from Jan 23, 2019

Conversation

Projects
6 participants
@s1na
Copy link
Contributor

commented Mar 9, 2018

It creates a new wallet, and changes the seed to the provided --key.

However I couldn't think of a good way to check if a wallet with this seed already exists, since it would require all of their passwords.

Add wallet_import_seed option to cli
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
Show resolved Hide resolved rai/node/node.cpp Outdated

@zhyatt zhyatt added this to the V18.0 milestone Dec 31, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 31, 2018

@SergiySW SergiySW moved this from Unscheduled to CP 3 (2018-01-23) in V18 Jan 1, 2019

@zhyatt zhyatt requested a review from cryptocode Jan 20, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM. That said: An alternative to this PR - to avoid CLI command proliferation - is to document how to combine existing commands (such as --wallet_create and --wallet_change_seed in this case)

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Jan 20, 2019

@cryptocode it does make more sense with #1567
I guess for unification -wallet_create + --wallet_change_seed are better

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Jan 23, 2019

Original PR was modified to allow seed & password set inside of --wallet_create command

@SergiySW SergiySW changed the title Add `wallet_import_seed` option to cli Modify `wallet_create` CLI to allow seed & password change Jan 23, 2019

@SergiySW SergiySW merged commit 24d3b75 into nanocurrency:master Jan 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.