Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node ID in RPC & QT wallet peers list #946

Merged
merged 22 commits into from Jan 28, 2019

Conversation

Projects
4 participants
@SergiySW
Copy link
Collaborator

commented Jul 4, 2018

No description provided.

SergiySW added some commits Jul 3, 2018

Add node_id field in RPC peers
Breaking old style endpoint: version

@SergiySW SergiySW changed the title node_id for RPC & QT wallet peers list Node ID in RPC & QT wallet peers list Jul 4, 2018

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2018

This is a breaking change for the peers RPC endpoint, right?

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 4, 2018

If someone is using version field there (few services?)

Optonal "deprecated" RPC peers
To return old style
@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 4, 2018

Now also with optinal "deprecated" field to return old style answer if anyone need this

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2018

I don't think making the change opt-out makes sense personally. I think we should either just make the breaking change or make the change opt-in. How does this affect the size and time of a peers rpc call BTW?

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2018

About +140% for size & about +100% for time (but still like 0.003-0.005 sec)

@zhyatt zhyatt requested a review from rkeene Jan 2, 2019

@zhyatt zhyatt added this to the V18.0 milestone Jan 2, 2019

@zhyatt zhyatt added this to Unscheduled in V18 Jan 2, 2019

@SergiySW SergiySW moved this from Unscheduled to CP 3 (2018-01-23) in V18 Jan 2, 2019

@rkeene

rkeene approved these changes Jan 17, 2019

Copy link
Contributor

left a comment

Thanks !

@SergiySW SergiySW merged commit 6f6506c into nanocurrency:master Jan 28, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.