Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node ID RPC #948

Merged
merged 21 commits into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@SergiySW
Copy link
Collaborator

commented Jul 5, 2018

RPC "node_id"
RPC "node_id_delete"

SergiySW added some commits Jul 5, 2018

Node ID RPC
RPC "node_id"
RPC "node_id_delete"
Fix

@rkeene rkeene added this to the V16.0 milestone Aug 24, 2018

@rkeene rkeene added the enhancement label Aug 24, 2018

@rkeene rkeene self-requested a review Aug 24, 2018

response_errors ();
}

void rai::rpc_handler::node_id_delete ()

This comment has been minimized.

Copy link
@rkeene

rkeene Aug 28, 2018

Contributor

Does deleting this cause any problems at runtime ? If we add this as an interface that we guarantee to support, are we going to have a bad time ?

This comment has been minimized.

Copy link
@SergiySW

SergiySW Aug 28, 2018

Author Collaborator

node_id loaded from store at startup as node.node_id. Then all calls to this variable. Deleting won't take effect until restart. And anyway each call to store.get_node_id can create new node_id

rpc_control_impl ();
if (!ec)
{
rai::transaction transaction (node.store.environment, nullptr, true);

This comment has been minimized.

Copy link
@rkeene

rkeene Aug 29, 2018

Contributor

The transaction constructor changed

@rkeene rkeene modified the milestones: V16.0, V17.0 Aug 29, 2018

@rkeene

rkeene approved these changes Oct 23, 2018

Copy link
Contributor

left a comment

Thanks !

@rkeene rkeene merged commit c4dfd0b into nanocurrency:master Oct 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.