Minimum bootstrap node version #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argakiig
approved these changes
Sep 13, 2018
|
Seems to run well on livenet, but a bunch of tests dislike the version change. Update: Tests pass locally, not sure what's going on with CI, forcing a rebuild and everything seems to pass. So I guess ok to merge. |
rkeene
added
enhancement
incomplete
cryptocode
force-pushed
the
minimum-bootstrap-version
branch
from
6af1b51
to
01f5af7
Compare
rkeene
removed
the
incomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 18% of the bootstrap targets are nodes that can never be in sync - this sets the minimum version to ensure the node groks VBH (please verify version). An alternative is to depeer them outright, or we can use this as a first step.