Basic confirm_req improvements #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Not sure if we want to log each cycle again |
|
Why did we stop logging each batch ? I think it's helpful to know when those kick off |
|
What is reason to log each batch? |
|
So that we can correlate the network activity to other things in the logs -- along with #1230 it should be much fewer than 20 lines in most cases |
Add a 0ms to 50ms random delay when scheduling more nodes to broadcast to. This should help stochastically balance this traffic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves logging to indicate how many representatives it is broadcasting to in each batch, and delays the second group by 50ms from the first group (instead of 0ms).