Skip to content

Conversation

@Hassmann
Copy link
Contributor

@Hassmann Hassmann commented Apr 13, 2019

Description

Miliseconds -> Milliseconds in code and documentation

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Hassmann public@hassmann.com

@nfbot
Copy link
Member

nfbot commented Apr 13, 2019

Hi @Hassmann,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks. 👍

@josesimoes
Copy link
Member

Please sign the CLA so this can be merged.

@Hassmann
Copy link
Contributor Author

I signed it, didn't show up yet.

@josesimoes
Copy link
Member

josesimoes commented Apr 14, 2019

From the message above (from the CLA bot) it seems that there is a mismatch from the user that you've used for the commits and the user you've used to sign the CLA. Please change your email on GitHub account to the same that you've used when submitting those commits. You can do this with a secondary email or even changing temporarily your current email.

You'll forgive these legalities but we have to be on the safe side... 😁

@Hassmann
Copy link
Contributor Author

I am very sorry, but the cla system continues to thank me for signing the agreement, only to keep the state at pending...

@josesimoes josesimoes merged commit ae7be89 into nanoframework:develop Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants