From 253167f12f21239a8da99d3f9b2de313947057da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Sim=C3=B5es?= <jose.simoes@eclo.solutions>
Date: Fri, 7 Jun 2019 16:04:45 +0100
Subject: [PATCH] Add SonarCloud
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Update Azure Pipelines.
- Add SonarCloud badges.
- Relocate signing key file to comply with SonarCloud GP.
- Remove attributes placed at wrong locations.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
---
 README.md                                           |   2 +-
 azure-pipelines.yml                                 |   2 ++
 source/nanoFramework.CoreLibrary/CoreLibrary.nfproj |   4 ++--
 source/nanoFramework.CoreLibrary/System/Type.cs     |   1 +
 source/{ => nanoFramework.CoreLibrary}/key.snk      | Bin
 5 files changed, 6 insertions(+), 3 deletions(-)
 rename source/{ => nanoFramework.CoreLibrary}/key.snk (100%)

diff --git a/README.md b/README.md
index 7b7a1fc4..33b5f593 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://github.com/nanoframework/Home/blob/master/LICENSE) [![NuGet](https://img.shields.io/nuget/dt/nanoFramework.CoreLibrary.svg)]() [![#yourfirstpr](https://img.shields.io/badge/first--timers--only-friendly-blue.svg)](https://github.com/nanoframework/Home/blob/master/CONTRIBUTING.md)
+[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=nanoframework_lib-CoreLibrary&metric=alert_status)](https://sonarcloud.io/dashboard?id=nanoframework_lib-CoreLibrary) [![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=nanoframework_lib-CoreLibrary&metric=reliability_rating)](https://sonarcloud.io/dashboard?id=nanoframework_lib-CoreLibrary) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://github.com/nanoframework/Home/blob/master/LICENSE) [![NuGet](https://img.shields.io/nuget/dt/nanoFramework.CoreLibrary.svg)]() [![#yourfirstpr](https://img.shields.io/badge/first--timers--only-friendly-blue.svg)](https://github.com/nanoframework/Home/blob/master/CONTRIBUTING.md)
 [![Discord](https://img.shields.io/discord/478725473862549535.svg)](https://discord.gg/gCyBu8T)
 
 
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index 2363d549..212f78d9 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -39,6 +39,8 @@ steps:
 # step from template @ nf-tools repo
 # all build, update and publish steps
 - template: azure-pipelines-templates/class-lib-build.yml@templates  
+  parameters:
+    soundCloudProject: 'nanoframework_lib-CoreLibrary'
 
 # update dependencies
 - task: UpdatenFDependencies@1
diff --git a/source/nanoFramework.CoreLibrary/CoreLibrary.nfproj b/source/nanoFramework.CoreLibrary/CoreLibrary.nfproj
index d9d2013b..f6c39f40 100644
--- a/source/nanoFramework.CoreLibrary/CoreLibrary.nfproj
+++ b/source/nanoFramework.CoreLibrary/CoreLibrary.nfproj
@@ -29,7 +29,7 @@
     <SignAssembly>true</SignAssembly>
   </PropertyGroup>
   <PropertyGroup>
-    <AssemblyOriginatorKeyFile>..\key.snk</AssemblyOriginatorKeyFile>
+    <AssemblyOriginatorKeyFile>key.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
   <PropertyGroup>
     <DelaySign>false</DelaySign>
@@ -375,7 +375,7 @@
     </NFMDP_PE_ExcludeClassByName>
   </ItemGroup>
   <ItemGroup>
-    <None Include="..\key.snk" />
+    <None Include="key.snk" />
     <None Include="packages.config" />
   </ItemGroup>
   <Import Project="$(NanoFrameworkProjectSystemPath)NFProjectSystem.CSharp.targets" Condition="Exists('$(NanoFrameworkProjectSystemPath)NFProjectSystem.CSharp.targets')" />
diff --git a/source/nanoFramework.CoreLibrary/System/Type.cs b/source/nanoFramework.CoreLibrary/System/Type.cs
index e39396fc..2a7dfdc1 100644
--- a/source/nanoFramework.CoreLibrary/System/Type.cs
+++ b/source/nanoFramework.CoreLibrary/System/Type.cs
@@ -48,6 +48,7 @@ public static Type GetType(String typeName)
             return GetTypeInternal(name, assemblyName, fVersion, ver);
         }
 
+        [Diagnostics.DebuggerHidden]
         [MethodImpl(MethodImplOptions.InternalCall)]
         private static extern Type GetTypeInternal(String typeName, string assemblyName, bool fVersion, int[] ver);
 
diff --git a/source/key.snk b/source/nanoFramework.CoreLibrary/key.snk
similarity index 100%
rename from source/key.snk
rename to source/nanoFramework.CoreLibrary/key.snk