-
-
Notifications
You must be signed in to change notification settings - Fork 3
Add List<T> and related classes
#153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
List<T> and related classes
4f0ac03 to
9fe03e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds the List<T> generic collection class and related interfaces to nanoFramework.System.Collections, addressing issue #782. The implementation includes comprehensive unit tests and updates dependencies to preview versions of nanoFramework.CoreLibrary (2.0.0-preview.20) and TestFramework (4.0.0-preview.44).
- Implements
List<T>with standard collection operations (Add, Remove, Insert, Clear, etc.) - Adds supporting generic interfaces:
ICollection<T>,IList<T>,IReadOnlyCollection<T>, andIReadOnlyList<T> - Includes 39 comprehensive unit tests covering various scenarios
- Updates native assembly version from 100.0.2.0 to 100.0.3.0
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| nanoFramework.System.Collections/Collections/Generic/List.cs | New List implementation with full collection functionality |
| nanoFramework.System.Collections/Collections/Generic/ICollection.cs | Generic collection interface definition |
| nanoFramework.System.Collections/Collections/Generic/IList.cs | Generic list interface definition |
| nanoFramework.System.Collections/Collections/Generic/IReadOnlyCollection.cs | Read-only collection interface |
| nanoFramework.System.Collections/Collections/Generic/IReadOnlyList.cs | Read-only list interface |
| nanoFramework.System.Collections/Collections/Generic/ICollectionDebugView.cs | Debug visualizer helper class |
| nanoFramework.System.Collections/Properties/AssemblyInfo.cs | Bumps native assembly version to 100.0.3.0 |
| Tests/GenericCollections/ListTests.cs | Comprehensive unit tests for List (39 test methods) |
| nanoFramework.System.Collections/packages.config | Updates CoreLibrary to 2.0.0-preview.20 |
| nanoFramework.System.Collections.nuspec | Updates CoreLibrary dependency to match |
| Tests/*/packages.config | Updates test dependencies to preview versions |
Comments suppressed due to low confidence (1)
nanoFramework.System.Collections/Collections/Generic/List.cs:313
- Condition always evaluates to 'true'.
if (true) // RuntimeHelpers.IsReferenceOrContainsReferences<T>())
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nanoFramework.System.Collections/Collections/Generic/ICollectionDebugView.cs
Show resolved
Hide resolved
|
@josesimoes I've opened a new pull request, #154, to work on those changes. Once the pull request is ready, I'll request review from you. |
4e9dfd6 to
14f1413
Compare
14f1413 to
18fcfd0
Compare
- Add unit tests. - Bump native assembly version. - Update nuspec
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ist.cs" This reverts commit f591b88.
18fcfd0 to
6135ffd
Compare
- Now using a struct including value types containing references.
|

Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: