Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Add processing of body variables as they can be a generic instance.

Motivation and Context

  • Minimization of assembly was failing because of this.

How Has This Been Tested?

  • MDP unit tests.
  • [tested against nanoclr buildId 57675].

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@nfbot nfbot added the Type: bug Something isn't working label Nov 5, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@josesimoes josesimoes closed this Nov 5, 2025
@nfbot nfbot added invalid and removed Type: bug Something isn't working labels Nov 5, 2025
@josesimoes josesimoes deleted the fix-generic-type-vars branch November 5, 2025 19:35
@josesimoes josesimoes restored the fix-generic-type-vars branch November 5, 2025 19:44
@josesimoes josesimoes reopened this Nov 5, 2025
@josesimoes josesimoes merged commit f6a67bf into nanoframework:develop Nov 5, 2025
5 checks passed
@josesimoes josesimoes deleted the fix-generic-type-vars branch November 5, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants