Skip to content

Conversation

@xas
Copy link
Contributor

@xas xas commented Feb 11, 2020

If none of these parameters are set in the command line :

  • listdfu
  • dfuid
  • dfufile

the application will crash with an ArgumentNullException
It is not even possible to launch the application in esp32 mode as the test fails just before

@nfbot
Copy link
Member

nfbot commented Feb 11, 2020

Hi @xas,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@claassistantio
Copy link

claassistantio commented Feb 11, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks 👍

@josesimoes josesimoes added the Type: Bug Something isn't working label Feb 12, 2020
@josesimoes josesimoes merged commit 545d071 into nanoframework:develop Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants