Skip to content

Conversation

@alberk8
Copy link
Contributor

@alberk8 alberk8 commented Sep 30, 2021

Description

  1. Remove the 4 Hour delay to download new Firmware.
  2. Always check with Cloudsmith API for the latest or fwversion as provided by user.
  3. If the firmware already exists on local disk then do not download from Cloudsmith
  4. Added Try Catch to CheckVersion so that it works even offline (without internet)

Motivation and Context

  • This allows for loading firmware version as and when it is needed without the time limitation or resorting to deleting the directory "c:\users\username.nanoframework" contents

How Has This Been Tested?

Get latest stable firmware
nanoff --target ESP32_WROOM_32 --update --serialport COM12

Get an older version of stable firmware
nanoff --target ESP32_WROOM_32 --update --serialport COM12 --fwversion 1.6.5.3

Get latest stable firmware
nanoff --target ESP32_WROOM_32 --update --serialport COM12

Get latest preview firmware
nanoff --target ESP32_WROOM_32 --update --serialport COM12 --preview

Get version 815 preview firmware
nanoff --target ESP32_WROOM_32 --update --serialport COM12 --preview --fwversion 1.7.1-preview.815

Get version 840 preview firmware
nanoff --target ESP32_WROOM_32 --update --serialport COM12 --preview --fwversion 1.7.1-preview.840

Get latest preview firmware
nanoff --target ESP32_WROOM_32 --update --serialport COM12 --preview

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Alway check for with CloudSmith on the Latest and or Fwversion if provided
Add Try Catch to CheckVersion in case there is no internet the program does not crash.  This enhancement will allow offline usage.
@nfbot
Copy link
Member

nfbot commented Sep 30, 2021

@alberk8 I've fixed the checklist for you.
FYI, the correct format is [x], no spaces inside brackets.

@nfbot
Copy link
Member

nfbot commented Sep 30, 2021

Hi @alberk8,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nanoframework nanoframework deleted a comment from nfbot Sep 30, 2021
Remove CheckVersion Enhancment to next Pull Request.
@nanoframework nanoframework deleted a comment from nfbot Oct 4, 2021
- Revert all changes.
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this. 👍🏻

@josesimoes josesimoes enabled auto-merge (squash) October 4, 2021 08:18
@josesimoes josesimoes merged commit b85abeb into nanoframework:develop Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants