Skip to content

Conversation

@Ellerbach
Copy link
Member

@Ellerbach Ellerbach commented Nov 17, 2021

Description

  • Fix default address for deployment partition.
  • Deployment address is not mandatory anymore.
  • Missing target name when calling UpdateFirmwareAsync for deploy operation.
  • Fix code to deploy only operation.
  • Bump version to 1.29.

Motivation and Context

  • Fix deployment app esp32.
  • Consider that deploy address is not mandatory (we have either a default one or one from the target partition table).
  • No need to flash bootloader when flashing to deployment partition (even if it's the only operation executing).
  • Improve associated documentation

How Has This Been Tested?

On a real ESP32 with the blinky app

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added the Type: Bug Something isn't working label Nov 17, 2021
@Ellerbach Ellerbach requested a review from josesimoes November 17, 2021 08:22
- Consider that deploy address is not mandatory (we have either a default one or one from the target partition table).
- No need to flash bootloader when flashing to deployment partition (even if it's the only operation executing).
- Improve descriptions for deploy option.
@josesimoes josesimoes changed the title Fix deployment app esp32 Fix deployment operation for ESP32 Nov 17, 2021
@josesimoes josesimoes enabled auto-merge (squash) November 17, 2021 09:14
@josesimoes josesimoes merged commit fb147f0 into develop Nov 17, 2021
@josesimoes josesimoes deleted the fix-app-deployment-esp32 branch November 18, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking-Change Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants