-
-
Notifications
You must be signed in to change notification settings - Fork 24
Refactor WebServer and add unit tests #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good all up and right direction. Thanks for putting love in the web server. There are few things I4ve seen using it recently in an advance project. So some notes for a further PR, not for this one.
|
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks.
|
@torbacz resolve the comments if you don't have anything else to add. We can then merge this one and move to other improvments. |
|
Yea, I think it's ready. And I've create a TODO list for future. |
Shall we create a specific project for the web server? I think I can set this up in nanoFramework org. So we can track what needs to be done with some description in cards. And the one working on something just move the card. So we don't double the efforts. Thoughts? |
|
@Ellerbach Sure, please create one and send me a link. I'll move list there. |
|
@Ellerbach yes please. We should be using projects a lot more than what we are today. |
|
@torbacz and @josesimoes the project is now created, I've invited @torbacz to the project. We (José and I) can invite anyone. So let's promote it whenever there is work to do and to take. I'll add the improvements I've seen. |

Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: