Skip to content

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 14, 2022

Description

  • Add processing in CMake to set a default value for ESP32_SPIRAM_FOR_IDF_ALLOCATION when the build option is not present.

Motivation and Context

  • A default value for this is requires as it can cause build errors when the option is not present thus making it an empty define for the memory allocation code.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

@josesimoes josesimoes merged commit 6909e33 into nanoframework:main Nov 14, 2022
@josesimoes josesimoes deleted the improve-spiram-idf-reservation branch November 14, 2022 11:37
aromaa pushed a commit to aromaa/nf-interpreter that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants