Fix tenant-deploy contract (per-app ns/project) + appset-count docs#27
Merged
Conversation
… docs From the core-repos quality audit. P0 (tenant deploy contract): apps-tenants.yaml targeted a shared `tenants-protohype` namespace + `tenant-protohype` AppProject that the operator never creates — it provisions per-Platform resources (namespace tenants-<app>, AppProject <app>). Retargeted each tenant Application to the per-app namespace + project (derived in the template from `.app`), matching what the operator reconciles. Paired with eks-agent-platform widening the AppProject sourceRepos to the nanohype org so the Application's source is allowed. Docs: ApplicationSet count 10 -> 16; corrected "all use matrix" — 3 appsets (addons-agent-operator, clusters-appset, portal-tenants) use other generators. Note: the audit's "region cluster-Secret label is unset" finding is a false positive — landing-zone cluster-bootstrap sets the `region` label on the in-cluster ArgoCD cluster Secret (bootstrap.tf), which is what the addons-agent-operator generator reads. No change needed there.
CI Results
All validations passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the core-repos quality audit.
P0 — tenant deploy contract
apps-tenants.yamltargeted a sharedtenants-protohypenamespace +tenant-protohypeAppProject that the operator never creates — it provisions per-Platform resources (tenants-<app>namespace,<app>AppProject). Retargeted each tenant Application to the per-app namespace + project (derived from.appin the template). Paired witheks-agent-platform#32(widens the AppProjectsourceReposso the Application's git source is allowed).Docs
addons-agent-operator,clusters-appset,portal-tenants) use other generators.Note — region finding was a false positive
The audit flagged
addons-agent-operatorreading an unsetregioncluster-Secret label. landing-zonecluster-bootstrapdoes set theregionlabel on the in-cluster ArgoCD cluster Secret (bootstrap.tf:258, on thesecret-type=clustersecret the generator reads), so standard-bootstrapped clusters are fine. No appset change.