Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing queue depths should just discard queue contents #51

Closed
gdamore opened this issue Oct 30, 2018 · 0 comments
Closed

Changing queue depths should just discard queue contents #51

gdamore opened this issue Oct 30, 2018 · 0 comments
Assignees

Comments

@gdamore
Copy link
Contributor

gdamore commented Oct 30, 2018

We have a bunch of logic intended to try to keep queue contents when a program changes the queue depth. This is silly.

Normally this is only done when the socket is first created. This is extra complexity that is not needed.

Furthermore, the new queue size might be smaller anyway, so queue contents can be dropped as a result of that. And generally any of the queues are in "best effort" cases anyway, where it is perfectly fine to drop messages on the floor.

@gdamore gdamore self-assigned this Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant