SPM: Fix iOS Build warning #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetteriAimonen
pushed a commit
that referenced
this pull request
Sep 14, 2020
simonseyer
added a commit
to simonseyer/KeychainAccess
that referenced
this pull request
Dec 2, 2021
This resolves `IPHONEOS_DEPLOYMENT_TARGET` warnings in newer Xcode versions. See nanopb/nanopb#585 for reference — I assume the same applies for this project. The toolchain will this way always choose the latest supported platform version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform specifications cause a build warning in Xcode 12. They're not necessary since nanopb supports all versions supported by Xcode versions that support Swift Package Manager.
Details in firebase/firebase-ios-sdk#6449, https://forums.swift.org/t/minimum-ios-version-xcode-12-and-build-warnings/40224, and https://github.com/apple/swift-evolution/blob/master/proposals/0236-package-manager-platform-deployment-settings.md