Skip to content

WebUI freeze #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
Timmy-the-nobody opened this issue Jan 2, 2024 · 10 comments
Closed
2 tasks done

WebUI freeze #994

Timmy-the-nobody opened this issue Jan 2, 2024 · 10 comments
Assignees
Labels
bug Something isn't working fixed Fixed or Implemented!

Comments

@Timmy-the-nobody
Copy link

Prerequisites

  • I'm sure both client and server are on the latest update.
  • I have read the console error message carefully (if applicable).

Your Environment

  • Version: 1.64.8
  • Operating System: Windows 11

Description

When sending too much events from JS to lua the whole WebUI page freezes and become unusable

Steps to reproduce the behavior

Install this package on your server:
webui-bug-package.zip

It contains a web page, which runs this every 5ms

setInterval(() => {
    Events.Call("SomeEvent");
    Events.Call("SomeEvent");
    Events.Call("SomeEvent");
    Events.Call("SomeEvent");
    Events.Call("SomeEvent");
    Events.Call("SomeEvent");
}, 5);

In the page there's a button that changes color when hovered
After a bit of time, hovering the button will not change it's color

Expected behavior

The page shouldn't freeze

Actual behavior

The page freeze, and the only way to unfreeze it is by reloading the package and recreate the WebUI instance

@Timmy-the-nobody Timmy-the-nobody added the bug Something isn't working label Jan 2, 2024
@gtnardy
Copy link
Member

gtnardy commented Jan 10, 2024

well I think it's quite expected when sending > 1000 events per second

@Timmy-the-nobody
Copy link
Author

well I think it's quite expected when sending > 1000 events per second

There should be a mitigation for that imo

@gtnardy
Copy link
Member

gtnardy commented Apr 22, 2025

@Timmy-the-nobody does it still happen for you?
How much time did you wait for the button to start getting unresponsive?

@gtnardy
Copy link
Member

gtnardy commented Apr 22, 2025

nvm after a few minutes it started lagging for me

@gtnardy
Copy link
Member

gtnardy commented Apr 22, 2025

nvm again, I think I only had the lagging because I had verbose logs enabled, and it was generating thousands of logs per second

@Timmy-the-nobody
Copy link
Author

@Timmy-the-nobody does it still happen for you? How much time did you wait for the button to start getting unresponsive?

I havn't tried again, but when it happened it was almost instant with the snippet i sent

@gtnardy
Copy link
Member

gtnardy commented Apr 23, 2025

@Timmy-the-nobody could you try again please (the snippet still works perfectly 😄)? (with logs verbose disabled then enabled) just so we can make sure?

@Timmy-the-nobody
Copy link
Author

@Timmy-the-nobody could you try again please (the snippet still works perfectly 😄)? (with logs verbose disabled then enabled) just so we can make sure?

Will try next time I launch the game

@Timmy-the-nobody
Copy link
Author

@gtnardy i tried again and it didn't crash at all, with and without verbose logs.
Before the freeze was instantaneous, I added a 50ms min mitigation between 2 events sent to make sure it'd never happen, but I guess I can remove it now

@gtnardy gtnardy self-assigned this Apr 24, 2025
@gtnardy gtnardy added the fixed Fixed or Implemented! label Apr 24, 2025
@gtnardy
Copy link
Member

gtnardy commented Apr 24, 2025

That's great to know, I will close the issue then! Probably it was fixed in some of my CEF improvements/bug fixes

@gtnardy gtnardy reopened this Apr 24, 2025
@gtnardy gtnardy closed this as completed Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Fixed or Implemented!
Development

No branches or pull requests

2 participants