Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use api version 0. #54

Merged
merged 10 commits into from
Oct 12, 2022
Merged

Update to use api version 0. #54

merged 10 commits into from
Oct 12, 2022

Conversation

laxect
Copy link
Collaborator

@laxect laxect commented Oct 1, 2022

This patch update series Types to use the new API version 0.

@laxect
Copy link
Collaborator Author

laxect commented Oct 1, 2022

This patch series will fix #53.

@laxect laxect linked an issue Oct 1, 2022 that may be closed by this pull request
* New subject has no staff and characters include, so disable code use
  them for now.
* New ep has no status.
* Add `--no-person` option for `bgm get`
* Add back actors to Anime.
* Fix Movie nfo gen.
@laxect laxect self-assigned this Oct 5, 2022
@laxect laxect mentioned this pull request Oct 5, 2022
@laxect
Copy link
Collaborator Author

laxect commented Oct 5, 2022

This patch update API call to version 0 for BGM. Bgm API has those changes:

  • No URL field for all Objects.
  • split subject API to subject + characters + persons(staffs)

So I have made some fixes to reflect API changes.

@laxect laxect marked this pull request as ready for review October 5, 2022 08:53
@laxect laxect requested a review from nanozuki October 5, 2022 08:53
@laxect laxect merged commit 9314be8 into main Oct 12, 2022
@laxect laxect deleted the patch-api-v0 branch October 12, 2022 08:39
@nanozuki
Copy link
Owner

@laxect Where is the document of API? Is this need update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access token not works
2 participants