Eliminate NET_4_0 preprocessing statement in NUnit2TestDomain.CreateDomain #48

Closed
pmcevoy opened this Issue May 16, 2012 · 2 comments

Projects

None yet

2 participants

@pmcevoy
pmcevoy commented May 16, 2012

The current implementation of NUnit2TestDomain.CreateDomain has two different ways of creating an app domain, with one of them only being used via conditional compilation using the NET_4_0 symbol

Upon investigation by Ryan, the NET_4_0 section would in fact be appropriate for 2.0 (http://www.mail-archive.com/nant-users%40lists.sourceforge.net/msg12282.html)

Enabling the looser way of constructing the app domain will allow us to use the NUnit2 task to run unit tests against MVC3 controllers that are using ViewBag and other DLR constructs.

Cheers
Pete

@rmboggs rmboggs was assigned May 16, 2012
@rmboggs
Member
rmboggs commented May 19, 2012

I have the fix on my local repo but I need to make some minor adjustments first before committing. Should go in for RC1.

@rmboggs rmboggs pushed a commit that referenced this issue May 20, 2012
Ryan Boggs Cleaned up some of the #if NET_4_0 preprocessing statements. It was d…
…iscovered that some of those statements were no longer necessary since the move to .net/mono 2.0. This also addresses issue #48.
f671f56
@rmboggs
Member
rmboggs commented May 20, 2012

Changes committed in time for RC1.

@rmboggs rmboggs closed this May 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment