Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue #65 tiny fix. #68

Merged
merged 1 commit into from Sep 19, 2012

Conversation

Projects
None yet
2 participants
Contributor

halad commented Sep 13, 2012

Issue #65, must apply Timeout to HttpWebRequest.ReadWriteTimeout, otherwise
when using the Get task for http/https, the request will timeout after the default
read write timeout of 5 minutes which may be less than the Timeout value
set on the task.

Issue #65, must apply Timeout to HttpWebRequest.ReadWriteTimeout, oth…
…erwise

when using the Get task for http/https, the request will timeout after the default
read write timeout of 5 minutes which may be less than the Timeout value
set on the task.
Owner

rmboggs commented Sep 14, 2012

Hi,

Very simple. I'll see about testing it this weekend but I have no problem with it at first glance. If test cases run normally, I'll commit after this weekend.

It would be cool to add a test to check this but testing for timing can be tricky.

Thanks,
Ryan

Owner

rmboggs commented Sep 19, 2012

Tested with mono-2.0, mono-4.0, net-2.0, and net-4.0. Will merge in a few minutes.

rmboggs added a commit that referenced this pull request Sep 19, 2012

@rmboggs rmboggs merged commit 08253e4 into nant:master Sep 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment