New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue 90 #91
Fix for Issue 90 #91
Conversation
…s compiler model.
… NAnt.NUnit2 and NDoc.Documenter.NAnt assemblies to ignore obsolete warnings for the time being until XslTransform can be replaced with XslCompiledTransform.
…recent XslTransform -> XslCompiledTransform changes.
I tried playing with this more but NAnt will ignore non-Public FrameworkConfigurable properties no matter what I do. They way I see it, there are two options:
IMO, the second option is messier and would require hardcoding the full path to the mcs.exe compiler like so:
This could lead to maintenance issues down the road if Mono moves the compiler to another directory. I think that the first option would be better for the long run. |
You should be able to use protected properties, but - in a way - these a still exposed (to derived classes). ----- Oorspronkelijk e-mail ----- Van: "Ryan Boggs" notifications@github.com I tried playing with this more but NAnt will ignore non-Public FrameworkConfigurable properties no matter what I do. They way I see it, there are two options:
IMO, the second option is messier and would require hardcoding the full path to the mcs.exe compiler like so: |
I'll give it a try. :) |
That works. I can commit this if you feel that it would be the best setup. |
Is this ok now? |
I hope I get the Windows build running with mono 3.0.x this weekend. |
The sooner the better but I am still waiting for feedback from @drieseng regarding the McsSdk protected var. I've played with it since my last update but I cannot successfully hide that property without losing the functionality needed to handle Mono's new compiler setup. |
I'll try to get a working build here this weekend to verify it. ----- Oorspronkelijk e-mail ----- Van: "Ryan Boggs" notifications@github.com The sooner the better but I am still waiting for feedback from @drieseng regarding the McsSdk protected var. I've played with it since my last update but I cannot successfully hide that property without losing the functionality needed to handle Mono's new compiler setup. |
I updated it to protected in my tree and that is working ok. It is set that way now in this pull request. I couldn't get it working with private or internal modifiers. I may try to improve the doc over the weekend for clarity purposes but that shouldn't impact testing from others. |
I'm running into resgen issues while trying to build this branch using mono on Windows. Any suggestions?
|
Sorry for the resgen noise. Problem was related to my cygwin setup. NAnt is building on my Win7 machine using mono-2.0 and mono-4.0 targets with this branch. |
Same here, I was able to build and test mono-2.0 and 4.0 with nmake and mono-3.0.6. Looks good from my point. |
@drieseng , can this go in? |
Rec'd confirmation from Gert via email. I'll merge tonight after I update the releasenotes file. |
- Unbreak build with new Mono compiler model [1] - Add LICENSE - Use USES=gmake Changes: http://nant.sourceforge.net/release/0.92/releasenotes.html Reference: nant/nant#91 [1] Obtained from: nant/nant@69c8ee9 [1]
- Unbreak build with new Mono compiler model [1] - Add LICENSE - Use USES=gmake Changes: http://nant.sourceforge.net/release/0.92/releasenotes.html Reference: nant/nant#91 [1] Obtained from: nant/nant@69c8ee9 [1] git-svn-id: svn+ssh://svn.freebsd.org/ports/head@325453 35697150-7ecd-e111-bb59-0022644237b5
- Unbreak build with new Mono compiler model [1] - Add LICENSE - Use USES=gmake Changes: http://nant.sourceforge.net/release/0.92/releasenotes.html Reference: nant/nant#91 [1] Obtained from: nant/nant@69c8ee9 [1]
This allows NAnt to build on Mono 3.0+
Successfully tested on the following setups:
The only thing I would like to try is Mono on Windows. I haven't been able to get it working on my Win box because I had trouble getting
make
working with the Mono installation in Windows through cygwin.