Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Introduce ylim in plot(hdnom.external.validate) #4

Closed
teigentler opened this issue May 11, 2016 · 5 comments
Closed

Suggestion: Introduce ylim in plot(hdnom.external.validate) #4

teigentler opened this issue May 11, 2016 · 5 comments

Comments

@teigentler
Copy link

@teigentler teigentler commented May 11, 2016

First of all, thank you very much for this great R-package!
Recently, I evaluated a model with external validation by hdnom.external.validate and plotted the result.
Because the model have similar AUR-values over time even small differences look dramatically because the plot scales automatically.
Would it be possible to include a ylim parameter in the plot function to define the plotting range?

Best wishes

Thomas

@teigentler
Copy link
Author

@teigentler teigentler commented Jun 3, 2016

solved it by setting it directly in the ggplot object

@Selaginella99
Copy link
Collaborator

@Selaginella99 Selaginella99 commented Jun 27, 2016

@teigentler Cheers! @road2stat

@nanxstats
Copy link
Owner

@nanxstats nanxstats commented Jul 5, 2016

@teigentler - thanks for the great suggestion! The argument ylim is now introduced in all validation plotting functions, namely, plot.hdnom.validate(), plot.hdnom.external.validate(), and plot.hdnom.compare.validate().

Use devtools::install_github("road2stat/hdnom") to try the development version. cc @Selaginella99

@nanxstats nanxstats closed this Jul 5, 2016
@nanxstats
Copy link
Owner

@nanxstats nanxstats commented Jul 5, 2016

This is updated in the CRAN version of hdnom (v4.0) which is available now.

@teigentler
Copy link
Author

@teigentler teigentler commented Jul 6, 2016

Thank’s so much. Keep on the good work.

Best wishes

Thomas

PD Dr. Thomas Eigentler,
Coordinator, Interdisciplinary Skin Cancer Center
Dept. of Dermatology
Liebermeisterstr. 25
72076 Tuebingen, Germany

UNIVERSITÄTSKLINIKUM TÜBINGEN
Südwestdeutsches Tumorzentrum – CCC Tübingen-Stuttgart

Tel. +49 7071 298 5748
Fax.: +49 7071 29 5265
Email: https://webmail.uni-tuebingen.de/imp/basic.php?mailbox=TWFpbC9zZW50&buid=12099&page=message thomas.eigentler@med.uni-tuebingen.de
Internet: http://www.hauttumorzentrum.de/ www.hauttumorzentrum.de

Von: Nan Xiao [mailto:notifications@github.com]
Gesendet: Dienstag, 5. Juli 2016 23:50
An: road2stat/hdnom hdnom@noreply.github.com
Cc: teigentler thomas@eigentler.de; Mention mention@noreply.github.com
Betreff: Re: [road2stat/hdnom] Suggestion: Introduce ylim in plot(hdnom.external.validate) (#4)

This is updated in the CRAN version of hdnom (v4.0) which is available now.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #4 (comment) , or mute the thread https://github.com/notifications/unsubscribe/ARw9tWUhy8WuR85pNSlia3HCHOFMi7Xkks5qStGegaJpZM4Ib3w9 . https://github.com/notifications/beacon/ARw9tRauSMJ-kp6nnnq1NwRIfnANeHY8ks5qStGegaJpZM4Ib3w9.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.