Repository navigation
Add pop() for Points and Shapes - #8072
Conversation
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8072 +/- ##
==========================================
+ Coverage 92.99% 93.05% +0.06%
==========================================
Files 703 704 +1
Lines 63417 63609 +192
==========================================
+ Hits 58972 59191 +219
+ Misses 4445 4418 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could we wait with this on #8006? It will be easier to fix merge conflicts on this side. |
| if not (0 <= index < len(self.data)): | ||
| return { | ||
| 'data': None, | ||
| 'properties': {}, |
There was a problem hiding this comment.
Should we leave out properties since it's replaced byu features? Are we still trying to keep it around for some transition reason? @andy-sweet Do you remember the status of this?
There was a problem hiding this comment.
Pretty sure this indeed shouldn't return properties, so I changed it :)
brisvag
left a comment
There was a problem hiding this comment.
As a followup, would be great to be able to go the other way: provide the same dictionary from pop and add a new point/shape with the given metadata/features already set.
|
@rahul713rk I took the liberty to push the couple remaining issues, hopefully we're able to merge this for 0.6.5 :) |
|
resolved the conflicts, let's see how this goes! |
pop for Points and Shapespop() for Points and Shapes
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
References & Related Issues
popmethod for Shapes and Points #8070removemethod for Shapes and Points #7964 , Addremove()in Shapes and Points #8031Description
popmethod for both thePointsandShapeslayers, enabling removal and return of point/shape data at a specified index.popmethod.