BaseModule.work() signature not compatible with Worker

[gst]

in Satellite.create_and_launch_worker() we have:

                    **target = module.work**   # module is a BaseModule instance
...
w = Worker(..., **target=target**, ...)

in Worker.init (1) we have :

        self._process = Process(target=target, **args=(s, returns_queue, self._c)**)

but in BaseModule class we have :

    def _main(self):   ** does not declare the 3 args as given to the Process in (1) **
        """module "main" method. Only used by external modules."""
        ...
    work = _main

so, actually (don't know since when, always?), any (external) module can't use the default work() method of BaseModule (== has to redefine it with a proper function signature), which is a pity because BaseModule.work() has the advantage of setting up different things, like the signal handler and also set the proc title.

[titilambert]

WOOOOOOH !!!!!
How all of this can work ?? This is a mystery !
We need Scooby Dooby

Good job man !

[gst]

How all of this can work ??

I guess all current (external only normally) modules are defining their own 'work' method (with the good arguments signature).. or something ;)

[gst]

anyway, from what I see / understand (I may miss some things still) :

Worker and BaseModule seem to define/duplicate certain things that could be again factorized etc.. but again it requires some non-trivial work to clarify all that.

[Seb-Solon]

Looks like the create_and_launch_worker method is only used by satellites (poller / reactionner) because all other daemon extend the main method of Sattellite. So the issue is only with to kind of worker module (named pipe work for poller but is not worker capable)

So basically all poller module we have implements their own work method. I guess you did not do it in the new poller module you are doing so you faced this issue :)

[gst]

I guess you did not do it in the new poller module you are doing so you faced this issue :)

that's exactly it ;)

[gst]

will be corrected by #1500