Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web UI : some modifications in Shinken core are necessary to help WebUI features #1654

Closed
wants to merge 2 commits into from
Closed

Web UI : some modifications in Shinken core are necessary to help WebUI features #1654

wants to merge 2 commits into from

Conversation

mohierf
Copy link
Contributor

@mohierf mohierf commented Jun 5, 2015

  • hostgroup_members property found in configuration is not stored in hostgroup object
  • same for servicegroup_members propery ...

With those properties, the WebUI is able to build links between groups ...

@mohierf
hostgroup_members property in hostgroup object
6315bd6 
Mainly for the WebUI to know the links between groups
@mohierf
servicegroup_members property in servicegroup object
8ade5c1 
Mainly for the WebUI to know the links between groups
mohierf added a commit to shinken-monitoring/mod-webui that referenced this pull request Jun 5, 2015
@mohierf
hosts and services groups, set level
3000bf4 
Define a group level (from 0 to ...) based upon hostgroup_members and
servicegroup_members properties defined in Shinken hostgroup and
servicegroup objects.
If PR shinken-solutions/shinken#1654 is accepted ... if
not, groups level is 0.
@mohierf
Copy link
Contributor Author

mohierf commented Jun 9, 2015

Why did this PR failed in Travis ?

@mohierf mohierf mentioned this pull request Jun 25, 2015
Closed
@ddurieux
Copy link
Contributor

But if it's used only in a module, add this function to the module no?

@mohierf mohierf mentioned this pull request Jul 11, 2015
Open
@mohierf mohierf mentioned this pull request Aug 27, 2015
Closed
@gst
Copy link
Contributor

gst commented Sep 25, 2015

@mohierf
it failed because of :

======================================================================
FAIL: test_all_props_are_tested (test_properties_defaults.TestHostgroup)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/naparuba/shinken/test/test_properties_defaults.py", line 74, in test_all_props_are_tested
    msg='unknown property %r found' % name)
AssertionError: 'hostgroup_members' not found in set(['use', 'realm', 'name', 'definition_order', 'hostgroup_name', 'notes', 'register', 'unknown_members', 'action_url', 'alias', 'notes_url', 'members', 'id', 'imported_from']) : unknown property 'hostgroup_members' found

you have only to adapt test_properties_defaults .. ;)

@olivierHa
Copy link
Collaborator

Any updates on this PR @mohierf ?

@mohierf
Copy link
Contributor Author

mohierf commented Dec 11, 2015

I close because I will submit a new PR with these features

@mohierf mohierf closed this Dec 11, 2015
@mohierf mohierf mentioned this pull request Dec 11, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mohierf @ddurieux @gst @olivierHa