feat(napi): support async class factory #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Brooooooklyn merged 1 commit into main from async-factory

Nov 6, 2023

Member

Brooooooklyn commented Nov 4, 2023

Close async static factories generate invalid code #1777


          feat(napi): support async class factory

23382eb

Brooooooklyn force-pushed the async-factory branch from 0dc3958 to 23382eb Compare

November 4, 2023 14:58

Member Author

Brooooooklyn commented Nov 4, 2023 •

edited

Loading

Current dependencies on/for this PR:

main
- PR feat(napi): support async class factory #1779 👈
  - PR fix(napi-sys): missing napi9 load on Windows #1780
    - PR feat(napi,sys): sync to napi9 #1781
      - PR feat: add experimental Env::get_module_file_name method #1783
        
        PR test(napi): add tests for napi9 features #1784
        
        PR style(napi): fix compile warning #1785
        
        PR style(napi): as ptr => ptr::cast #1786

This stack of pull requests is managed by Graphite.

This was referenced Nov 4, 2023

fix(napi-sys): missing napi9 load on Windows #1780

Merged

feat(napi,sys): sync to napi9 #1781

Merged

feat: add experimental Env::get_module_file_name method #1783

Merged

test(napi): add tests for napi9 features #1784

Merged

style(napi): fix compile warning #1785

Merged

style(napi): as ptr => ptr::cast #1786

Merged

Member Author

Brooooooklyn commented Nov 6, 2023 •

edited

Loading

Merge activity

Nov 5, 9:58 PM: @Brooooooklyn started a stack merge that includes this pull request via Graphite.
Nov 5, 9:58 PM: @Brooooooklyn merged this pull request with Graphite.

Brooooooklyn merged commit 546b108 into main

Brooooooklyn deleted the async-factory branch

November 6, 2023 02:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet