Skip to content

feat(napi): support External for compact mode #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Brooooooklyn merged 1 commit into from
May 26, 2024
Merged

feat(napi): support External for compact mode #2125

Brooooooklyn merged 1 commit into from
May 26, 2024

Conversation

@richerfu
Copy link
Contributor

@richerfu richerfu commented May 24, 2024

  1. compact mode support more complex data-struct which use ToNapiValue.
  2. Set the status of JsExternal as deprecated.
  3. Update the External and CleanupHook example.

@Brooooooklyn Brooooooklyn merged commit a3b0187 into napi-rs:main May 26, 2024
Brooooooklyn pushed a commit that referenced this pull request Jun 25, 2024
@richerfu @Brooooooklyn
feat(napi): support External for compact mode and add JsExternal as d…
bb7ea75 
…eprecated (#2125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@richerfu @Brooooooklyn