fix(napi-derive): call flush on the BufWriter #2195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mandated by the Rust doc of the BufWriter. We've also seen bugs where the data doesn't seem to be flushed properly, and thus the CLI fails to parse JSONs emitted by napi-derive. This might be it, or not, but flushing shouldn't hurt.
Brooooooklyn
changed the title
Brooooooklyn
pushed a commit
that referenced
this pull request
Jul 23, 2024
This is mandated by the Rust doc of the BufWriter. We've also seen bugs where the data doesn't seem to be flushed properly, and thus the CLI fails to parse JSONs emitted by napi-derive. This might be it, or not, but flushing shouldn't hurt.
kodiakhq bot
referenced
this pull request
in X-oss-byte/Canary-nextjs
Jul 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [napi-derive](https://togithub.com/napi-rs/napi-rs) | dependencies | patch | `2.16.9` -> `2.16.10` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>napi-rs/napi-rs (napi-derive)</summary> ### [`v2.16.10`](https://togithub.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.10) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/napi-derive@2.16.9...napi-derive@2.16.10) #### What Changed - fix(napi-derive): call flush on the BufWriter by [@​lbarthon](https://togithub.com/lbarthon) in [https://github.com/napi-rs/napi-rs/pull/2195](https://togithub.com/napi-rs/napi-rs/pull/2195) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.16.9...napi-derive@2.16.10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
DonIsaac
referenced
this pull request
in oxc-project/oxc-jest
Jul 31, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [napi-derive](https://togithub.com/napi-rs/napi-rs) | dependencies | patch | `2.16.6` -> `2.16.8` | --- ### Release Notes <details> <summary>napi-rs/napi-rs (napi-derive)</summary> ### [`v2.16.10`](https://togithub.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.10) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/napi-derive@2.16.9...napi-derive@2.16.10) #### What Changed - fix(napi-derive): call flush on the BufWriter by [@​lbarthon](https://togithub.com/lbarthon) in [https://github.com/napi-rs/napi-rs/pull/2195](https://togithub.com/napi-rs/napi-rs/pull/2195) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.16.9...napi-derive@2.16.10 ### [`v2.16.9`](https://togithub.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.9) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/napi-derive@2.16.8...napi-derive@2.16.9) #### What's Changed - fix: napi getter macros by [@​SyMind](https://togithub.com/SyMind) in [https://github.com/napi-rs/napi-rs/pull/2188](https://togithub.com/napi-rs/napi-rs/pull/2188) #### New Contributors - [@​SyMind](https://togithub.com/SyMind) made their first contribution in [https://github.com/napi-rs/napi-rs/pull/2188](https://togithub.com/napi-rs/napi-rs/pull/2188) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.16.8...napi-derive@2.16.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10am on monday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/oxc-project/oxc-jest). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
kodiakhq bot
referenced
this pull request
in X-oss-byte/Canary-nextjs
Sep 17, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [napi](https://redirect.github.com/napi-rs/napi-rs) | dependencies | patch | `2.16.9` -> `2.16.10` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>napi-rs/napi-rs (napi)</summary> ### [`v2.16.10`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.10) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi@2.16.9...napi@2.16.10) #### What Changed - fix(napi-derive): call flush on the BufWriter by [@​lbarthon](https://redirect.github.com/lbarthon) in [https://github.com/napi-rs/napi-rs/pull/2195](https://redirect.github.com/napi-rs/napi-rs/pull/2195) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.16.9...napi-derive@2.16.10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mandated by the Rust doc of the BufWriter. We've also seen bugs where the data doesn't seem to be flushed properly, and thus the CLI fails to parse JSONs emitted by napi-derive. This might be it, or not, but flushing shouldn't hurt.
@Brooooooklyn could this be added on napi2 too please? 🙏