fix(napi): allow ThreadsafeFunction in Either #2204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: ae0a495 | Previous: 327998d | Ratio |
|---|---|---|---|
noop#napi-rs |
86674878 ops/sec (±0.37%) |
86557024 ops/sec (±0.32%) |
1.00 |
noop#JavaScript |
822841432 ops/sec (±0.07%) |
819141533 ops/sec (±0.17%) |
1.00 |
Plus number#napi-rs |
21034061 ops/sec (±0.98%) |
22847574 ops/sec (±0.22%) |
1.09 |
Plus number#JavaScript |
820690476 ops/sec (±0.12%) |
819041099 ops/sec (±0.12%) |
1.00 |
Create buffer#napi-rs |
656292 ops/sec (±12.31%) |
669019 ops/sec (±13.1%) |
1.02 |
Create buffer#JavaScript |
3868160 ops/sec (±1.7%) |
3241372 ops/sec (±2.13%) |
0.84 |
createArray#createArrayJson |
53973 ops/sec (±0.23%) |
53471 ops/sec (±0.41%) |
0.99 |
createArray#create array for loop |
10052 ops/sec (±0.21%) |
9959 ops/sec (±0.92%) |
0.99 |
createArray#create array with serde trait |
10047 ops/sec (±0.33%) |
10051 ops/sec (±0.16%) |
1.00 |
getArrayFromJs#get array from json string |
24336 ops/sec (±0.57%) |
24191 ops/sec (±0.57%) |
0.99 |
getArrayFromJs#get array from serde |
13746 ops/sec (±0.5%) |
13781 ops/sec (±0.32%) |
1.00 |
getArrayFromJs#get array with for loop |
16233 ops/sec (±0.31%) |
15922 ops/sec (±0.51%) |
0.98 |
Get Set property#Get Set from native#u32 |
591868 ops/sec (±8.62%) |
565558 ops/sec (±13.41%) |
0.96 |
Get Set property#Get Set from JavaScript#u32 |
545252 ops/sec (±2.33%) |
535717 ops/sec (±2.56%) |
0.98 |
Get Set property#Get Set from native#string |
563446 ops/sec (±11.37%) |
567355 ops/sec (±12%) |
1.01 |
Get Set property#Get Set from JavaScript#string |
513781 ops/sec (±1.87%) |
519765 ops/sec (±2.29%) |
1.01 |
Async task#spawn task |
26746 ops/sec (±0.6%) |
27241 ops/sec (±0.75%) |
1.02 |
Async task#ThreadSafeFunction |
9492 ops/sec (±1.25%) |
9495 ops/sec (±0.73%) |
1.00 |
Async task#Tokio future to Promise |
33654 ops/sec (±0.73%) |
34051 ops/sec (±0.81%) |
1.01 |
Query#query * 100 |
3496 ops/sec (±1.36%) |
3505 ops/sec (±1.36%) |
1.00 |
Query#query * 1 |
26626 ops/sec (±0.65%) |
26607 ops/sec (±0.65%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
deleted the
08-03-fix_napi_allow_threadsafefunction_in_either
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.