Skip to content

fix(napi-derive): string enum validate logic#2213

Merged
Brooooooklyn merged 1 commit intomainfrom
08-10-fix_napi-derive_string_enum_validate_logic
Aug 10, 2024
Merged

fix(napi-derive): string enum validate logic#2213
Brooooooklyn merged 1 commit intomainfrom
08-10-fix_napi-derive_string_enum_validate_logic

Conversation

@Brooooooklyn
Copy link
Member

No description provided.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 68d9d9d Previous: 4abda0e Ratio
noop#napi-rs 87031805 ops/sec (±0.08%) 86576750 ops/sec (±0.56%) 0.99
noop#JavaScript 823350219 ops/sec (±0.07%) 821206730 ops/sec (±0.12%) 1.00
Plus number#napi-rs 22249899 ops/sec (±0.16%) 21772061 ops/sec (±0.33%) 0.98
Plus number#JavaScript 822488154 ops/sec (±0.08%) 820055123 ops/sec (±0.1%) 1.00
Create buffer#napi-rs 672621 ops/sec (±12%) 677660 ops/sec (±12.82%) 1.01
Create buffer#JavaScript 3729334 ops/sec (±2.4%) 3364385 ops/sec (±2.52%) 0.90
createArray#createArrayJson 54799 ops/sec (±0.4%) 54073 ops/sec (±0.41%) 0.99
createArray#create array for loop 10072 ops/sec (±0.36%) 10072 ops/sec (±0.31%) 1
createArray#create array with serde trait 10091 ops/sec (±0.31%) 10001 ops/sec (±0.54%) 0.99
getArrayFromJs#get array from json string 24555 ops/sec (±0.49%) 24505 ops/sec (±0.55%) 1.00
getArrayFromJs#get array from serde 13367 ops/sec (±0.62%) 13799 ops/sec (±0.44%) 1.03
getArrayFromJs#get array with for loop 16142 ops/sec (±0.33%) 16166 ops/sec (±0.41%) 1.00
Get Set property#Get Set from native#u32 588021 ops/sec (±12.38%) 547165 ops/sec (±12.42%) 0.93
Get Set property#Get Set from JavaScript#u32 544811 ops/sec (±2.43%) 532741 ops/sec (±2.3%) 0.98
Get Set property#Get Set from native#string 565682 ops/sec (±11.68%) 554432 ops/sec (±11.8%) 0.98
Get Set property#Get Set from JavaScript#string 529701 ops/sec (±1.88%) 514778 ops/sec (±1.88%) 0.97
Async task#spawn task 27019 ops/sec (±0.57%) 27013 ops/sec (±0.6%) 1.00
Async task#ThreadSafeFunction 9479 ops/sec (±0.81%) 9460 ops/sec (±0.71%) 1.00
Async task#Tokio future to Promise 33469 ops/sec (±1.27%) 33861 ops/sec (±1.01%) 1.01
Query#query * 100 3603 ops/sec (±0.77%) 3557 ops/sec (±1.35%) 0.99
Query#query * 1 26673 ops/sec (±1.41%) 26672 ops/sec (±0.51%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@Brooooooklyn Brooooooklyn merged commit d84fc42 into main Aug 10, 2024
@Brooooooklyn Brooooooklyn deleted the 08-10-fix_napi-derive_string_enum_validate_logic branch August 10, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant