fix(napi-derive): warning in empty enum codegen#2214
Merged
Brooooooklyn merged 1 commit intomainfrom Aug 10, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 7582323 | Previous: d84fc42 | Ratio |
|---|---|---|---|
noop#napi-rs |
86991334 ops/sec (±0.11%) |
85834424 ops/sec (±1.52%) |
0.99 |
noop#JavaScript |
823392865 ops/sec (±0.07%) |
821315121 ops/sec (±0.08%) |
1.00 |
Plus number#napi-rs |
22941246 ops/sec (±0.14%) |
22810555 ops/sec (±0.58%) |
0.99 |
Plus number#JavaScript |
822640241 ops/sec (±0.09%) |
819840901 ops/sec (±0.1%) |
1.00 |
Create buffer#napi-rs |
677121 ops/sec (±13.07%) |
664264 ops/sec (±12.68%) |
0.98 |
Create buffer#JavaScript |
3436579 ops/sec (±1.88%) |
3495946 ops/sec (±2.76%) |
1.02 |
createArray#createArrayJson |
54796 ops/sec (±0.22%) |
54323 ops/sec (±0.49%) |
0.99 |
createArray#create array for loop |
10043 ops/sec (±0.52%) |
10056 ops/sec (±0.27%) |
1.00 |
createArray#create array with serde trait |
10012 ops/sec (±0.64%) |
10017 ops/sec (±0.56%) |
1.00 |
getArrayFromJs#get array from json string |
24557 ops/sec (±0.49%) |
24459 ops/sec (±0.45%) |
1.00 |
getArrayFromJs#get array from serde |
13868 ops/sec (±0.54%) |
13936 ops/sec (±0.32%) |
1.00 |
getArrayFromJs#get array with for loop |
16330 ops/sec (±0.32%) |
16097 ops/sec (±0.06%) |
0.99 |
Get Set property#Get Set from native#u32 |
573417 ops/sec (±12.7%) |
573471 ops/sec (±12.74%) |
1.00 |
Get Set property#Get Set from JavaScript#u32 |
548763 ops/sec (±2.44%) |
537870 ops/sec (±2.57%) |
0.98 |
Get Set property#Get Set from native#string |
550102 ops/sec (±13.4%) |
563056 ops/sec (±12.09%) |
1.02 |
Get Set property#Get Set from JavaScript#string |
520136 ops/sec (±2.15%) |
515551 ops/sec (±2.51%) |
0.99 |
Async task#spawn task |
26348 ops/sec (±0.74%) |
26895 ops/sec (±0.89%) |
1.02 |
Async task#ThreadSafeFunction |
9576 ops/sec (±0.46%) |
9297 ops/sec (±0.81%) |
0.97 |
Async task#Tokio future to Promise |
33171 ops/sec (±1.01%) |
33382 ops/sec (±0.99%) |
1.01 |
Query#query * 100 |
3559 ops/sec (±1.29%) |
3535 ops/sec (±1.29%) |
0.99 |
Query#query * 1 |
25435 ops/sec (±0.58%) |
26395 ops/sec (±0.67%) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
deleted the
08-10-fix_napi-derive_warning_in_empty_enum_codegen
branch
Brooooooklyn
added a commit
that referenced
this pull request
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.