fix(napi): windows function registration timing#2248
Merged
Brooooooklyn merged 4 commits intomainfrom Sep 12, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
This was referenced Sep 12, 2024
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: c553a9f | Previous: 58bcb64 | Ratio |
|---|---|---|---|
noop#napi-rs |
85937509 ops/sec (±1.21%) |
86750615 ops/sec (±0.23%) |
1.01 |
noop#JavaScript |
813653529 ops/sec (±0.69%) |
822821177 ops/sec (±0.07%) |
1.01 |
Plus number#napi-rs |
20944510 ops/sec (±1.61%) |
22855203 ops/sec (±0.13%) |
1.09 |
Plus number#JavaScript |
816233439 ops/sec (±0.15%) |
821943110 ops/sec (±0.09%) |
1.01 |
Create buffer#napi-rs |
653343 ops/sec (±12.71%) |
667980 ops/sec (±11.33%) |
1.02 |
Create buffer#JavaScript |
2972912 ops/sec (±6.61%) |
3899719 ops/sec (±3.07%) |
1.31 |
createArray#createArrayJson |
53409 ops/sec (±0.16%) |
54318 ops/sec (±0.43%) |
1.02 |
createArray#create array for loop |
9759 ops/sec (±0.52%) |
10098 ops/sec (±0.47%) |
1.03 |
createArray#create array with serde trait |
9974 ops/sec (±0.62%) |
10084 ops/sec (±0.68%) |
1.01 |
getArrayFromJs#get array from json string |
24289 ops/sec (±0.46%) |
24333 ops/sec (±0.49%) |
1.00 |
getArrayFromJs#get array from serde |
13759 ops/sec (±0.49%) |
13886 ops/sec (±0.32%) |
1.01 |
getArrayFromJs#get array with for loop |
16011 ops/sec (±0.32%) |
15397 ops/sec (±0.56%) |
0.96 |
Get Set property#Get Set from native#u32 |
564247 ops/sec (±12.94%) |
569590 ops/sec (±12.9%) |
1.01 |
Get Set property#Get Set from JavaScript#u32 |
533987 ops/sec (±2.3%) |
545466 ops/sec (±2.52%) |
1.02 |
Get Set property#Get Set from native#string |
561447 ops/sec (±11.27%) |
548375 ops/sec (±12.57%) |
0.98 |
Get Set property#Get Set from JavaScript#string |
509613 ops/sec (±2.09%) |
517650 ops/sec (±2.07%) |
1.02 |
Async task#spawn task |
26775 ops/sec (±1.16%) |
26878 ops/sec (±0.56%) |
1.00 |
Async task#ThreadSafeFunction |
9323 ops/sec (±0.87%) |
9585 ops/sec (±0.78%) |
1.03 |
Async task#Tokio future to Promise |
33605 ops/sec (±1.47%) |
34497 ops/sec (±1.25%) |
1.03 |
Query#query * 100 |
3515 ops/sec (±0.3%) |
3538 ops/sec (±0.46%) |
1.01 |
Query#query * 1 |
26295 ops/sec (±1.41%) |
27017 ops/sec (±1.39%) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
added a commit
that referenced
this pull request
Sep 12, 2024
* fix(napi): windows function registration timing * fix clippy issue * upgrade zig version * pin rust version on zig cross compile ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.