chore(napi): remove once_cell#2271
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 75f4c36 | Previous: f704b4a | Ratio |
|---|---|---|---|
noop#napi-rs |
84457668 ops/sec (±2.44%) |
86062935 ops/sec (±0.25%) |
1.02 |
noop#JavaScript |
816039740 ops/sec (±0.14%) |
814081017 ops/sec (±0.21%) |
1.00 |
Plus number#napi-rs |
22440691 ops/sec (±0.63%) |
22716094 ops/sec (±0.19%) |
1.01 |
Plus number#JavaScript |
815099823 ops/sec (±0.15%) |
813616649 ops/sec (±0.1%) |
1.00 |
Create buffer#napi-rs |
659991 ops/sec (±12.75%) |
643191 ops/sec (±13.74%) |
0.97 |
Create buffer#JavaScript |
3136075 ops/sec (±2.23%) |
3067423 ops/sec (±2.43%) |
0.98 |
createArray#createArrayJson |
54041 ops/sec (±0.13%) |
54421 ops/sec (±0.36%) |
1.01 |
createArray#create array for loop |
9896 ops/sec (±0.4%) |
9859 ops/sec (±0.57%) |
1.00 |
createArray#create array with serde trait |
9906 ops/sec (±0.17%) |
9885 ops/sec (±0.55%) |
1.00 |
getArrayFromJs#get array from json string |
24345 ops/sec (±0.62%) |
24447 ops/sec (±0.31%) |
1.00 |
getArrayFromJs#get array from serde |
12282 ops/sec (±0.41%) |
12986 ops/sec (±0.39%) |
1.06 |
getArrayFromJs#get array with for loop |
16600 ops/sec (±0.41%) |
16502 ops/sec (±0.15%) |
0.99 |
Get Set property#Get Set from native#u32 |
581356 ops/sec (±11.9%) |
564109 ops/sec (±12.76%) |
0.97 |
Get Set property#Get Set from JavaScript#u32 |
542518 ops/sec (±2.37%) |
544793 ops/sec (±2.21%) |
1.00 |
Get Set property#Get Set from native#string |
564431 ops/sec (±11.4%) |
554412 ops/sec (±12.38%) |
0.98 |
Get Set property#Get Set from JavaScript#string |
519552 ops/sec (±2.02%) |
509594 ops/sec (±1.94%) |
0.98 |
Async task#spawn task |
26449 ops/sec (±0.35%) |
26223 ops/sec (±0.46%) |
0.99 |
Async task#ThreadSafeFunction |
9411 ops/sec (±0.71%) |
9352 ops/sec (±0.76%) |
0.99 |
Async task#Tokio future to Promise |
32266 ops/sec (±0.84%) |
31207 ops/sec (±0.93%) |
0.97 |
Query#query * 100 |
3555 ops/sec (±1.25%) |
3545 ops/sec (±0.51%) |
1.00 |
Query#query * 1 |
27016 ops/sec (±0.8%) |
27040 ops/sec (±0.76%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
force-pushed
the
09-23-chore_napi_remove_once_cell
branch
from
ac34c7f to
75f4c36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.