refactor!(napi,napi-derive): add lifetime to ClassInstance#2286
Merged
Brooooooklyn merged 1 commit intomainfrom Oct 2, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: dd934ad | Previous: 5fbe9ce | Ratio |
|---|---|---|---|
noop#napi-rs |
84960190 ops/sec (±1.21%) |
85301708 ops/sec (±1%) |
1.00 |
noop#JavaScript |
818218642 ops/sec (±0.08%) |
817396618 ops/sec (±0.14%) |
1.00 |
Plus number#napi-rs |
22916179 ops/sec (±0.35%) |
23065166 ops/sec (±0.3%) |
1.01 |
Plus number#JavaScript |
817950912 ops/sec (±0.09%) |
816423143 ops/sec (±0.2%) |
1.00 |
Create buffer#napi-rs |
670777 ops/sec (±13.13%) |
680501 ops/sec (±12.63%) |
1.01 |
Create buffer#JavaScript |
4175714 ops/sec (±2.98%) |
3459984 ops/sec (±1.86%) |
0.83 |
createArray#createArrayJson |
52920 ops/sec (±0.48%) |
54214 ops/sec (±0.26%) |
1.02 |
createArray#create array for loop |
9932 ops/sec (±0.11%) |
9920 ops/sec (±0.41%) |
1.00 |
createArray#create array with serde trait |
9896 ops/sec (±0.35%) |
9944 ops/sec (±0.22%) |
1.00 |
getArrayFromJs#get array from json string |
23741 ops/sec (±0.5%) |
24536 ops/sec (±0.11%) |
1.03 |
getArrayFromJs#get array from serde |
13680 ops/sec (±0.39%) |
13159 ops/sec (±0.52%) |
0.96 |
getArrayFromJs#get array with for loop |
16650 ops/sec (±0.62%) |
16834 ops/sec (±0.11%) |
1.01 |
Get Set property#Get Set from native#u32 |
607194 ops/sec (±8.58%) |
582528 ops/sec (±11.89%) |
0.96 |
Get Set property#Get Set from JavaScript#u32 |
560124 ops/sec (±2.15%) |
556297 ops/sec (±2.2%) |
0.99 |
Get Set property#Get Set from native#string |
571625 ops/sec (±11.09%) |
569002 ops/sec (±10.79%) |
1.00 |
Get Set property#Get Set from JavaScript#string |
529533 ops/sec (±1.74%) |
522662 ops/sec (±1.94%) |
0.99 |
Async task#spawn task |
26387 ops/sec (±0.96%) |
26368 ops/sec (±0.3%) |
1.00 |
Async task#ThreadSafeFunction |
9489 ops/sec (±0.7%) |
9498 ops/sec (±0.99%) |
1.00 |
Async task#Tokio future to Promise |
32532 ops/sec (±0.78%) |
32484 ops/sec (±0.88%) |
1.00 |
Query#query * 100 |
3607 ops/sec (±0.68%) |
3651 ops/sec (±0.52%) |
1.01 |
Query#query * 1 |
27651 ops/sec (±0.92%) |
27939 ops/sec (±0.95%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
force-pushed
the
10-01-refactor_napi_napi-derive_add_lifetime_to_classinstance
branch
from
263e420 to
dd934ad
Compare
Brooooooklyn
deleted the
10-01-refactor_napi_napi-derive_add_lifetime_to_classinstance
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.