refactor!(napi): remove clone fn on ThreadsafeFunction#2291
Merged
Brooooooklyn merged 1 commit intomainfrom Oct 7, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: b951457 | Previous: 9a6f01a | Ratio |
|---|---|---|---|
noop#napi-rs |
85162464 ops/sec (±0.92%) |
85956557 ops/sec (±0.25%) |
1.01 |
noop#JavaScript |
817580385 ops/sec (±0.14%) |
814653153 ops/sec (±0.11%) |
1.00 |
Plus number#napi-rs |
23072733 ops/sec (±0.27%) |
22891046 ops/sec (±0.18%) |
0.99 |
Plus number#JavaScript |
816773571 ops/sec (±0.11%) |
814724831 ops/sec (±0.12%) |
1.00 |
Create buffer#napi-rs |
665418 ops/sec (±12.33%) |
586542 ops/sec (±14.23%) |
0.88 |
Create buffer#JavaScript |
3700149 ops/sec (±2.77%) |
3051601 ops/sec (±3.23%) |
0.82 |
createArray#createArrayJson |
54059 ops/sec (±0.68%) |
53369 ops/sec (±0.56%) |
0.99 |
createArray#create array for loop |
9964 ops/sec (±0.57%) |
9945 ops/sec (±0.5%) |
1.00 |
createArray#create array with serde trait |
9950 ops/sec (±0.59%) |
9953 ops/sec (±0.51%) |
1.00 |
getArrayFromJs#get array from json string |
24174 ops/sec (±0.51%) |
23810 ops/sec (±0.72%) |
0.98 |
getArrayFromJs#get array from serde |
12939 ops/sec (±0.38%) |
13650 ops/sec (±0.46%) |
1.05 |
getArrayFromJs#get array with for loop |
16192 ops/sec (±0.16%) |
16189 ops/sec (±0.43%) |
1.00 |
Get Set property#Get Set from native#u32 |
580053 ops/sec (±12.1%) |
565598 ops/sec (±8.78%) |
0.98 |
Get Set property#Get Set from JavaScript#u32 |
524843 ops/sec (±11.02%) |
524347 ops/sec (±9.15%) |
1.00 |
Get Set property#Get Set from native#string |
596777 ops/sec (±1.9%) |
562594 ops/sec (±11.88%) |
0.94 |
Get Set property#Get Set from JavaScript#string |
525736 ops/sec (±1.81%) |
511704 ops/sec (±2.32%) |
0.97 |
Async task#spawn task |
26174 ops/sec (±0.27%) |
26303 ops/sec (±0.62%) |
1.00 |
Async task#ThreadSafeFunction |
9349 ops/sec (±1.03%) |
9179 ops/sec (±1.08%) |
0.98 |
Async task#Tokio future to Promise |
31671 ops/sec (±1.36%) |
32589 ops/sec (±1.01%) |
1.03 |
Query#query * 100 |
3600 ops/sec (±0.61%) |
3436 ops/sec (±1.06%) |
0.95 |
Query#query * 1 |
27182 ops/sec (±0.8%) |
26877 ops/sec (±0.73%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
force-pushed
the
10-07-refactor_napi_remove_clone_fn_on_threadsafefunction
branch
from
988bb6a to
b951457
Compare
Member
Author
Merge activity
|
Brooooooklyn
deleted the
10-07-refactor_napi_remove_clone_fn_on_threadsafefunction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.