chore(napi): env doesn't need to be mut#2292
Merged
Brooooooklyn merged 1 commit intomainfrom Oct 7, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 54c4af5 | Previous: 9a6f01a | Ratio |
|---|---|---|---|
noop#napi-rs |
85941192 ops/sec (±0.31%) |
85956557 ops/sec (±0.25%) |
1.00 |
noop#JavaScript |
812236508 ops/sec (±0.26%) |
814653153 ops/sec (±0.11%) |
1.00 |
Plus number#napi-rs |
22828597 ops/sec (±0.47%) |
22891046 ops/sec (±0.18%) |
1.00 |
Plus number#JavaScript |
811353582 ops/sec (±0.26%) |
814724831 ops/sec (±0.12%) |
1.00 |
Create buffer#napi-rs |
619791 ops/sec (±12.86%) |
586542 ops/sec (±14.23%) |
0.95 |
Create buffer#JavaScript |
3171018 ops/sec (±2.38%) |
3051601 ops/sec (±3.23%) |
0.96 |
createArray#createArrayJson |
53722 ops/sec (±0.43%) |
53369 ops/sec (±0.56%) |
0.99 |
createArray#create array for loop |
9797 ops/sec (±0.42%) |
9945 ops/sec (±0.5%) |
1.02 |
createArray#create array with serde trait |
9888 ops/sec (±0.17%) |
9953 ops/sec (±0.51%) |
1.01 |
getArrayFromJs#get array from json string |
23977 ops/sec (±0.28%) |
23810 ops/sec (±0.72%) |
0.99 |
getArrayFromJs#get array from serde |
12973 ops/sec (±0.27%) |
13650 ops/sec (±0.46%) |
1.05 |
getArrayFromJs#get array with for loop |
16490 ops/sec (±0.48%) |
16189 ops/sec (±0.43%) |
0.98 |
Get Set property#Get Set from native#u32 |
602317 ops/sec (±8.09%) |
565598 ops/sec (±8.78%) |
0.94 |
Get Set property#Get Set from JavaScript#u32 |
540380 ops/sec (±2.41%) |
524347 ops/sec (±9.15%) |
0.97 |
Get Set property#Get Set from native#string |
563382 ops/sec (±10.52%) |
562594 ops/sec (±11.88%) |
1.00 |
Get Set property#Get Set from JavaScript#string |
520144 ops/sec (±1.94%) |
511704 ops/sec (±2.32%) |
0.98 |
Async task#spawn task |
26055 ops/sec (±0.71%) |
26303 ops/sec (±0.62%) |
1.01 |
Async task#ThreadSafeFunction |
9028 ops/sec (±1.43%) |
9179 ops/sec (±1.08%) |
1.02 |
Async task#Tokio future to Promise |
32337 ops/sec (±1.03%) |
32589 ops/sec (±1.01%) |
1.01 |
Query#query * 100 |
3572 ops/sec (±0.35%) |
3436 ops/sec (±1.06%) |
0.96 |
Query#query * 1 |
27210 ops/sec (±1%) |
26877 ops/sec (±0.73%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.