Skip to content

feat(napi,napi-derive): allow lifetime in Class#2298

Merged
Brooooooklyn merged 1 commit intomainfrom
10-10-feat_napi_napi-derive_allow_lifetime_in_class
Oct 10, 2024
Merged

feat(napi,napi-derive): allow lifetime in Class#2298
Brooooooklyn merged 1 commit intomainfrom
10-10-feat_napi_napi-derive_allow_lifetime_in_class

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 7dc3be7 Previous: 7246732 Ratio
noop#napi-rs 84894183 ops/sec (±0.26%) 86089576 ops/sec (±0.41%) 1.01
noop#JavaScript 804497917 ops/sec (±0.17%) 816926898 ops/sec (±0.22%) 1.02
Plus number#napi-rs 22687043 ops/sec (±0.62%) 23334228 ops/sec (±0.21%) 1.03
Plus number#JavaScript 802078193 ops/sec (±0.13%) 813995011 ops/sec (±0.16%) 1.01
Create buffer#napi-rs 357470 ops/sec (±17.97%) 627887 ops/sec (±13.65%) 1.76
Create buffer#JavaScript 1454961 ops/sec (±5.52%) 3444579 ops/sec (±1.65%) 2.37
createArray#createArrayJson 48679 ops/sec (±0.59%) 53747 ops/sec (±0.36%) 1.10
createArray#create array for loop 9820 ops/sec (±0.61%) 9962 ops/sec (±0.48%) 1.01
createArray#create array with serde trait 9899 ops/sec (±0.24%) 9985 ops/sec (±0.41%) 1.01
getArrayFromJs#get array from json string 23027 ops/sec (±0.93%) 23842 ops/sec (±0.15%) 1.04
getArrayFromJs#get array from serde 13532 ops/sec (±0.35%) 13676 ops/sec (±0.29%) 1.01
getArrayFromJs#get array with for loop 16594 ops/sec (±0.44%) 16791 ops/sec (±0.11%) 1.01
Get Set property#Get Set from native#u32 493020 ops/sec (±13.91%) 576182 ops/sec (±12.13%) 1.17
Get Set property#Get Set from JavaScript#u32 443189 ops/sec (±14.91%) 552569 ops/sec (±2.16%) 1.25
Get Set property#Get Set from native#string 465290 ops/sec (±22.12%) 569367 ops/sec (±10.83%) 1.22
Get Set property#Get Set from JavaScript#string 454888 ops/sec (±4.16%) 514793 ops/sec (±2.01%) 1.13
Async task#spawn task 25135 ops/sec (±0.48%) 25939 ops/sec (±0.61%) 1.03
Async task#ThreadSafeFunction 7095 ops/sec (±0.97%) 9393 ops/sec (±0.76%) 1.32
Async task#Tokio future to Promise 31238 ops/sec (±1.29%) 31755 ops/sec (±1.09%) 1.02
Query#query * 100 2604 ops/sec (±1.12%) 3551 ops/sec (±0.42%) 1.36
Query#query * 1 24287 ops/sec (±2.15%) 27201 ops/sec (±0.87%) 1.12

This comment was automatically generated by workflow using github-action-benchmark.

@Brooooooklyn Brooooooklyn force-pushed the 10-10-feat_napi_napi-derive_allow_lifetime_in_class branch from f605426 to 54c883f Compare October 10, 2024 01:48
@Brooooooklyn Brooooooklyn force-pushed the 10-10-feat_napi_napi-derive_allow_lifetime_in_class branch from 54c883f to 7dc3be7 Compare October 10, 2024 01:58
@Brooooooklyn Brooooooklyn merged commit afd081d into main Oct 10, 2024
@Brooooooklyn Brooooooklyn deleted the 10-10-feat_napi_napi-derive_allow_lifetime_in_class branch October 10, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant