refactor!(napi): Ref::unref accept &mut self instead of self#2308
Merged
Brooooooklyn merged 1 commit intomainfrom Oct 14, 2024
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 2fc10e1 | Previous: a38a24c | Ratio |
|---|---|---|---|
noop#napi-rs |
80930167 ops/sec (±0.21%) |
86099099 ops/sec (±0.14%) |
1.06 |
noop#JavaScript |
818796666 ops/sec (±0.05%) |
814272251 ops/sec (±0.17%) |
0.99 |
Plus number#napi-rs |
22986490 ops/sec (±0.15%) |
22867471 ops/sec (±0.75%) |
0.99 |
Plus number#JavaScript |
817048188 ops/sec (±0.16%) |
812768396 ops/sec (±0.21%) |
0.99 |
Create buffer#napi-rs |
659889 ops/sec (±13.29%) |
636988 ops/sec (±13.11%) |
0.97 |
Create buffer#JavaScript |
3493337 ops/sec (±2.06%) |
3245089 ops/sec (±2.69%) |
0.93 |
createArray#createArrayJson |
52835 ops/sec (±0.64%) |
52634 ops/sec (±0.27%) |
1.00 |
createArray#create array for loop |
9910 ops/sec (±0.52%) |
9904 ops/sec (±0.65%) |
1.00 |
createArray#create array with serde trait |
9905 ops/sec (±0.51%) |
9907 ops/sec (±0.44%) |
1.00 |
getArrayFromJs#get array from json string |
23731 ops/sec (±0.18%) |
23670 ops/sec (±0.66%) |
1.00 |
getArrayFromJs#get array from serde |
13594 ops/sec (±0.32%) |
13661 ops/sec (±0.27%) |
1.00 |
getArrayFromJs#get array with for loop |
16691 ops/sec (±0.06%) |
16724 ops/sec (±0.09%) |
1.00 |
Get Set property#Get Set from native#u32 |
560313 ops/sec (±13.04%) |
568139 ops/sec (±12.08%) |
1.01 |
Get Set property#Get Set from JavaScript#u32 |
538714 ops/sec (±2.32%) |
528346 ops/sec (±2.23%) |
0.98 |
Get Set property#Get Set from native#string |
562674 ops/sec (±11.74%) |
560537 ops/sec (±12.2%) |
1.00 |
Get Set property#Get Set from JavaScript#string |
527110 ops/sec (±1.85%) |
527234 ops/sec (±1.99%) |
1.00 |
Async task#spawn task |
25758 ops/sec (±0.66%) |
25993 ops/sec (±0.39%) |
1.01 |
Async task#ThreadSafeFunction |
9093 ops/sec (±4.35%) |
8961 ops/sec (±1.23%) |
0.99 |
Async task#Tokio future to Promise |
31450 ops/sec (±1.03%) |
32098 ops/sec (±0.83%) |
1.02 |
Query#query * 100 |
3601 ops/sec (±0.95%) |
3591 ops/sec (±0.45%) |
1.00 |
Query#query * 1 |
27565 ops/sec (±0.78%) |
27124 ops/sec (±1.11%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
force-pushed
the
10-14-refactor_napi_ref_unref_accept_mut_self_instead_of_self
branch
from
893e8dc to
2fc10e1
Compare
Member
Author
Merge activity
|
Brooooooklyn
deleted the
10-14-refactor_napi_ref_unref_accept_mut_self_instead_of_self
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.