refactor!(napi): pass self to Task::finally instread of &mut self#2309
Merged
Brooooooklyn merged 1 commit intoOct 14, 2024
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: fb38808 | Previous: 72afae3 | Ratio |
|---|---|---|---|
noop#napi-rs |
86324473 ops/sec (±0.2%) |
85245615 ops/sec (±0.89%) |
0.99 |
noop#JavaScript |
817595944 ops/sec (±0.08%) |
818733588 ops/sec (±0.07%) |
1.00 |
Plus number#napi-rs |
22995977 ops/sec (±0.62%) |
23153665 ops/sec (±0.32%) |
1.01 |
Plus number#JavaScript |
817725125 ops/sec (±0.08%) |
817376295 ops/sec (±0.08%) |
1.00 |
Create buffer#napi-rs |
622264 ops/sec (±12.98%) |
672787 ops/sec (±12.04%) |
1.08 |
Create buffer#JavaScript |
3807441 ops/sec (±2.69%) |
3758146 ops/sec (±7.99%) |
0.99 |
createArray#createArrayJson |
54032 ops/sec (±0.42%) |
52923 ops/sec (±0.84%) |
0.98 |
createArray#create array for loop |
9936 ops/sec (±0.42%) |
9934 ops/sec (±0.46%) |
1.00 |
createArray#create array with serde trait |
9938 ops/sec (±0.35%) |
9902 ops/sec (±0.28%) |
1.00 |
getArrayFromJs#get array from json string |
24608 ops/sec (±0.37%) |
23856 ops/sec (±0.51%) |
0.97 |
getArrayFromJs#get array from serde |
13614 ops/sec (±0.45%) |
13527 ops/sec (±0.51%) |
0.99 |
getArrayFromJs#get array with for loop |
16545 ops/sec (±1.45%) |
16655 ops/sec (±0.19%) |
1.01 |
Get Set property#Get Set from native#u32 |
574567 ops/sec (±12.36%) |
580673 ops/sec (±12.48%) |
1.01 |
Get Set property#Get Set from JavaScript#u32 |
550422 ops/sec (±2.42%) |
557935 ops/sec (±2.07%) |
1.01 |
Get Set property#Get Set from native#string |
567475 ops/sec (±11.14%) |
559712 ops/sec (±11.06%) |
0.99 |
Get Set property#Get Set from JavaScript#string |
517821 ops/sec (±1.9%) |
518396 ops/sec (±1.84%) |
1.00 |
Async task#spawn task |
26444 ops/sec (±0.28%) |
26348 ops/sec (±0.6%) |
1.00 |
Async task#ThreadSafeFunction |
9523 ops/sec (±0.76%) |
9450 ops/sec (±0.41%) |
0.99 |
Async task#Tokio future to Promise |
32173 ops/sec (±1.07%) |
32384 ops/sec (±0.84%) |
1.01 |
Query#query * 100 |
3597 ops/sec (±0.81%) |
3656 ops/sec (±0.55%) |
1.02 |
Query#query * 1 |
27546 ops/sec (±0.7%) |
27203 ops/sec (±0.79%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
force-pushed
the
10-14-refactor_napi_ref_unref_accept_mut_self_instead_of_self
branch
from
893e8dc to
2fc10e1
Compare
Brooooooklyn
force-pushed
the
10-14-refactor_napi_pass_self_to_task_finally_instread_of_mut_self
branch
from
153cc3e to
7d67666
Compare
Base automatically changed from
10-14-refactor_napi_ref_unref_accept_mut_self_instead_of_self
to
main
October 14, 2024 03:14
Brooooooklyn
force-pushed
the
10-14-refactor_napi_pass_self_to_task_finally_instread_of_mut_self
branch
from
7d67666 to
fb38808
Compare
Member
Author
Merge activity
|
Brooooooklyn
deleted the
10-14-refactor_napi_pass_self_to_task_finally_instread_of_mut_self
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.